sgeisler/cargo-remote

MacOS needs updating `rsync` to work

TriplEight opened this issue · 7 comments

The thing what really helped cargo-remote to work on macos is

brew install rsync

The patch #3 didn't help at all. Neither before nor after brew install rsync.
Please follow @kianenigma advice there.

Ok, but did #3 break anything? I'm not a Mac user, so I can't test this. But I'll add a remark to the README. Do Mac devs know what brew is or should I link to somewhere?

Do Mac devs know what brew is or should I link to somewhere?

a Dev should know what it is I suppose.

Ok, but did #3 break anything? I'm not a Mac user, so I can't test this.

I just compiled and linked the latest master and it still works fine for me, given the updated rsync. Though I don't get colored output so I will revert.

So #3 broke the coloring and it worked before? Then I don't understand @TriplEight's comment in #3 tbh. If that's the case I'll revert #3 too.

Yeah don't know why. Maybe it is the wasm runner that does not show them?
Screenshot 2019-11-21 at 10 55 01

also the progress bar is gone for some reason

Did you test with the pre-#3 version too?

Ah, I see it's about cargo and shouldn't be affected by #3. Were you running a version with the #9 patch?

So #3 broke the coloring and it worked before? Then I don't understand @TriplEight's comment in #3 tbh. If that's the case I'll revert #3 too.

I also don't have a Mac to test on, was asking colleagues to do that xD