sgentle/caniuse-cmd

Note supers are hard to spot

Opened this issue · 4 comments

The supers for notes are the same color as the percentage to which they belong making them hard to see. It would be nice if they were all a consistent color (not the red/yellow/green) so I could see the note, and spot which version it applies to easily.

caniuse let example

Good idea! Would you be willing to submit a pull request?

You'll probably want to change this line where the supers are displayed next to the version and this one where they're displayed next to the actual note.

I figure both places should be the same, either white/unstyled or a new and different colour from the existing red/yellow/green, right? I'm happy with whatever looks best.

If I'm reading it right, I would also have to change how the colors are applied? I was going to submit a pull request but coffee script is foreign to me. Maybe I can spend some time figuring it out and get a PR in eventually when I do.

I'm not sure if you'd have to change how the colours are applied... are you talking about whether you'd need to do the colouring at a different level so that the super colour and the warning/spec colour don't interfere? I'm pretty sure the color module handles nesting okay. But maybe I'm misunderstanding your question...

You might find coffeescript isn't as daunting as it seems, these days it's basically ES6 with significant whitespace. :D If anything's giving you trouble feel free to pipe up here, I'm happy to help.

Space to note itself is ok, to version i think create too space.

caniuse_spacespng