Seems like a lot of files aren't being included where they should be
Opened this issue · 9 comments
First I kept running into an error where blanketOptions
was null. To fix that, in blanket-options.js
I had to switch this:
if (typeof exports === 'undefined') {
blanket.options(options);
} else {
module.exports = options;
}
to this:
if (typeof blanket !== 'undefined') {
blanket.options(options);
}
if (typeof exports !== 'undefined') {
module.exports = options;
}
and then in test-helper.js
I had to add this line:
import './blanket-options';
At this point if I were to run ember s
and go to the /tests/
page it would run my unit tests, but if I added the ?coverage
at the end (or if I ran ember test
) I'd still get the following error:
ReferenceError: Can't find variable: moduleLoaderFinish
Source: http://localhost:4200/assets/test-loader.js:116
Including assets/blanket-loader.js
right before assets/test-loader.js
fixed this issue, but it seems like all of this should be working out of the box, or at the very least there should be some documentation about this whole process.
Ran into the same issue, first an error with
undefined 'blanket.options('cliOptions').autostart'
Then the null problem on blanket. @wesm87's solution fixed the issue for now (thanks !) but this indeed should be at least documented.
did you run ember install ember-cli-blanket
such that the blueprint ran?
what version of ember?
the blueprint is responsible for adding blanket-options.js to your index.html
I did ember install ember-cli-blanket
and the versions I'm using are the following :
- ember-cli-blanket : 0.8.0
- ember-cli : 1.13.15
- ember : 2.3.0
@sglazner - I wonder if the blueprint (which is using positional insertions) is failing b/c the default template has changed
On Feb 23, 2016, at 8:35 AM, Pierre-Julien VILLOUD notifications@github.com wrote:
I did ember install ember-cli-blanket and the versions I'm using are the following :
ember-cli-blanket : 0.8.0
ember-cli : 1.13.15
ember : 2.3.0
—
Reply to this email directly or view it on GitHub #113 (comment).
I also did an ember install
and here are the versions I'm using:
- ember: 2.3.1
- ember-cli: 2.3.0
- ember-cli-blanket: 0.8.0
@wesm87's solution helped me as well (thank you!). I ran ember install ember-cli-blanket
but it did not modify tests/index.html. In order to get the install to work I had to change the loader.js version in bower.json to "loader.js": "ember-cli/loader.js#3.6.1",
because ember-cli@1.13.15 uses loader.js#3.4.0
.
I'm using the following versions of things:
- ember: 1.13.12
- ember-cli: 1.13.15
- ember-cli-blanket: 0.9.1
I ran into the same error undefined 'blanket.options('cliOptions').autostart w/ a brand new ember app. This can be replicated on ember-cli v2.7.0 by doing
ember new brokenApp
ember cd brokenApp
ember install ember-cli-blanket
ember test
@wesm87's solution fixed the issue. If that solution is satisfactory, I can work on a PR. Let me know.
@vcipriani I'd be happy to accept a PR on this, looks like #154 is likely related as well
PR would be great, as this is breaking my addons currently!