shabinarayan/google-diff-match-patch

r70 has broken diff_match_patch_test.cpp

Closed this issue · 2 comments

I just downloaded the new diff_match_patch_20101028.zip.

I don't think this line (from r70) in diff_match_patch_test.cpp is correct:

896 +     QString resultStr =  + "\t" + sprintf(str, "%s\t%d", results.first, 
boolArray.count());


Original issue reported on code.google.com by chris...@gmail.com on 29 Oct 2010 at 1:34

You are quite right.  Looks like the version control system was used 
incorrectly.  That line should be:
896:  QString resultStr = 
QString("%1\t%2").arg(results.first).arg(boolArray.count());

Since this 'just' appears to be a broken test, and the DMP code appears to be 
correct, I'll forego an emergency push, but instead include this the next 
update which is scheduled for Friday or Monday.

Thanks for pointing this out.  My apologies.

Original comment by neil.fra...@gmail.com on 29 Oct 2010 at 4:38

  • Changed state: Started
  • Added labels: Priority-High
  • Removed labels: Priority-Medium
Fixed.  A new version has been committed and uploaded.

Original comment by neil.fra...@gmail.com on 29 Oct 2010 at 3:33

  • Changed state: Fixed