shadow-maint/shadow

tarball has tests in tests/tests

zeha opened this issue · 3 comments

zeha commented

The 4.15.2 and the 4.16.0 tarballs have a surprising layout for the test files:

shadow-4.16.0/tests
shadow-4.16.0/tests/unit
shadow-4.16.0/tests/unit/test_xasprintf.c
shadow-4.16.0/tests/unit/test_zustr2stp.c
shadow-4.16.0/tests/unit/test_logind.c
shadow-4.16.0/tests/unit/test_strncpy.c
shadow-4.16.0/tests/unit/Makefile.am
shadow-4.16.0/tests/unit/test_strtcpy.c
shadow-4.16.0/tests/unit/test_adds.c
shadow-4.16.0/tests/unit/test_atoi_strtoi.c
shadow-4.16.0/tests/unit/test_chkname.c
shadow-4.16.0/tests/unit/Makefile.in
shadow-4.16.0/tests/unit/test_sprintf.c
shadow-4.16.0/tests/tests
shadow-4.16.0/tests/tests/cktools
...
shadow-4.16.0/tests/tests/unit
shadow-4.16.0/tests/tests/unit/test_xasprintf.c
shadow-4.16.0/tests/tests/unit/test_zustr2stp.c
shadow-4.16.0/tests/tests/unit/Makefile
shadow-4.16.0/tests/tests/unit/test_logind.c
shadow-4.16.0/tests/tests/unit/test_strncpy.c
shadow-4.16.0/tests/tests/unit/Makefile.am
shadow-4.16.0/tests/tests/unit/test_strtcpy.c
shadow-4.16.0/tests/tests/unit/.gitignore
shadow-4.16.0/tests/tests/unit/test_adds.c
shadow-4.16.0/tests/tests/unit/test_atoi_strtoi.c
shadow-4.16.0/tests/tests/unit/Makefile.in
shadow-4.16.0/tests/tests/unit/test_sprintf.c
...

So at least tests/unit is shipped twice, and IMO it shouldn't be in a different directory than in git.

Could this just become like in git, please?

hallyn commented

Ah, this is probably because tests/unit is in SUBDIRS in Makefile.am, since before tests/ was in EXTRA_DIST. We should probably just drop that from SUBDIRS.

alejandro-colomar commented