shadow-maint/shadow

sulogin is not being installed

Opened this issue · 4 comments

firasuke commented

Hey there,

Thank for your time and effort.

I noticed that shadow's sulogin is being built under src/, but it is not being installed when running make install. Having checked src/Makefile it seems that it is under noinst_PROGRAMS.

Is this intended behavior? Does this mean that util-linux's sulogin is the version to use?

Thanks in advance!

alejandro-colomar commented

Is this intended behavior?

Having an explicit line in the Makefile.am, I'd say yes, it was intended. But I don't know why it was intended. The git-blame(1) says it's a very old line.

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

firasuke commented

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

util-linux's version of sulogin is indeed what is being used by almost all distributions. I guess shadow's sulogin could be dropped then?

alejandro-colomar commented

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

util-linux's version of sulogin is indeed what is being used by almost all distributions.

re: almost: Did you find any one that doesn't?

I guess shadow's sulogin could be dropped then?

It depends on your response to the above question. If none at all are using it, maybe it would make sense to remove it, since I wouldn't trust a program that nobody has been using at all for years. If there's any user, I guess we should keep it.

firasuke commented

re: almost: Did you find any one that doesn't?

Yes, after a basic search on publicly available code on GitHub, I found some slackware recipes and some Chimera Linux recipes that are explicitly installing shadow's version of sulogin.