Need to make mobile responsive

Question

Need to make mobile responsive

justin808 opened this issue 7 years ago · 16 comments

justin808 commented 7 years ago

We need to make this example mobile responsive.

Any takers?

Answer 1 · 2017-09-01T23:58:17.000Z

I'd be interested in taking a crack at it.

Answer 2 · 2017-09-02T09:07:08.000Z

That would be awesome. I'll mark you as the owner of this. I look forward to seeing your PR.

Answer 3 · 2017-09-02T09:07:50.000Z

@tfantina you only get 1 week to be the owner and show progress.

Answer 4 · 2017-09-04T23:37:43.000Z

@justin808 Hey I haven't done anything with webpacker_lite, every time I try to launch the local server I get this error:

WebpackerLite can't find the manifest file: /path/react-webpack-rails-tutorial/public/webpack/development/manifest.json
        Possible causes:
          1. You have not invoked webpack.
          2. You have misconfigured WebpackerLite's config/webpacker_lite.yml file.
          3. Your Webpack configuration is not creating a manifest.

I'm not sure what sort of additional configuration is needed in the yml file, I've also installed the webpack-manifest-plugin but I'm not sure how to proceed, although I am still really interested in this and I think I can make the example responsive I don't have a lot of experience with react_on_rails or webpacker_lite.

Answer 5 · 2017-09-08T13:01:48.000Z

I've been messing with this for several days and I just can't get it working. I will continue to do so when I have more time if not for this for my own curiosity but for the time being, I'm very sorry, I don't think I'll be able to give the pull request in time.

Answer 6 · 2017-09-09T01:13:18.000Z

@tfantina rebase on top of master...I've updated to React on Rails 9.0.

Answer 7 · 2017-11-21T15:48:41.000Z

@justin808, I built a responsive app on top of a forked version of this tutorial. It has gotten a little behind this repo, it isn't using Webpacker yet, and I have been waiting to update it, hoping to hold onto hot reloading : ).

It uses flexbox and media queries, with some site-wide SCSS mixins handling the responsiveness to keep things dry. It wasn't easy to build, since I had to remove Bootstrap to get responsive flexbox to work.

It is really a different app with its own client/app/bundles, but a lot heavier on design, typography, svg graphics, and that kind of thing.

If you think it would be a good idea, this approach could be applied to make your app responsive. It could be rolled in as a "no-Bootstrap" branch (assuming it is impossible to make flexbox work properly with Bootstrap in place).

Answer 8 · 2017-11-22T03:11:01.000Z

@reconstructions I'm open to considering this!

Answer 9 · 2017-11-22T03:19:40.000Z

@reconstructions Please send me an email justin@shakacode.com.

Answer 10 · 2019-02-20T11:51:35.000Z

I m willing to take this on!

Answer 11 · 2019-04-23T01:55:46.000Z

@justin808 I will take care this issue. Since this is using bootstrap, it seems like it is already responsive. Do you have any special design? Or if I make this app look good, is it ok?

Answer 12 · 2019-05-25T20:47:19.000Z

If this issue is still available, I would like to grab it as part of my application process.

Answer 13 · 2022-04-29T13:52:41.000Z

@justin808 I have the fix for this from my own project, can I take this issue?

Answer 14 · 2022-06-06T09:45:02.000Z

@KnoxMajor that would be awesome! Sorry for the slow reply!

Answer 15 · 2022-06-07T20:02:01.000Z

right on, @justin808 I'll take it

Answer 16 · 2023-08-02T18:49:32.000Z

This project is responsive now.