shakacode/react-webpack-rails-tutorial

Add example of rescript to this tutorial

justin808 opened this issue · 15 comments

See https://github.com/shakacode/bs-react-on-rails.

I'd like to see another tab that shows Reason ML.

image

I will give it a shot. Just letting you know that I am working on it.

@coderhs Any update?

Hi @justin808 !
I would like to grab this issue.

@justin808 added a new tab. Please provide me permissions to push changes. Thanks!

screenshot 2019-02-22 at 7 04 38 pm

@Sirbuland just push a PR.

@justin808 Could u please give me access. I have added the 'Reason ML' link added on top navigation bar pointing to https://reasonml.github.io. I want to create pull request.
Thanks

@Sirbuland @shahidjutt72 The way to do this is to fork and submit a PR.

And @Sirbuland, the link would point to a demo of using Reason with the rest of the code, not to the Reason docs.

Hello! Is anyone working this, @justin808 ?

@pullmana8, nope not right now! Want to give it a shot?

@justin808 Yes I would love to.

Hi @justin808, I grabbed the issue and created a pull request #487. Please let me know if it is working. Thank you.

Reason ML Navigation Bar

Reason ML Nav Bar

@justin808
Do you still want this? If so, what was the issue with the PR?

Nice to have example of ReScript here. However, we need to check @alex35mil first.

I just want to make it clear. We want a page demonstrating components using ReScript.
If I am right, there is another question. I know ReactOnRails supports ReScript. Does ReactRails support ReScript? If not, this feature conflicts with #503

Added in #552