shannonmoeller/regx

TypeScript support?

Closed this issue · 1 comments

cshaa commented

I've found this package only recently and it's really awesome! It solves many issues I've had with vanilla regex in JS for ages. However, lots of people nowadays use TypeScript rather than pure JavaScript. Adding type declarations would make it possible to use this package with TS, too.

I'll happily make a PR for this, if that's something you're interested in.

Thank you very much for asking before submitting a TypeScript PR. I get a lot of unsolicited TypeScript PRs without warning and it's a bummer as I don't accept them. I'm not currently interested in adding TypeScript support to my libraries. If I ever do, it would likely be via JSDoc syntax and // @ts-check pragmas as a linting step.

If you would like to maintain it, perhaps a PR to https://github.com/DefinitelyTyped/DefinitelyTyped which adds @types/regx is in order.

https://gist.github.com/shannonmoeller/3f212ca98829f4f1f7df02e9df763063#what-about-typescript