sharenowTech/AnyMaps

Various changes on my fork, which you might like to include?

Opened this issue · 0 comments

johan12345 commented

Hi! Thank you very much for the AnyMaps library. I am working on implementing it into my EVMap project (https://github.com/johan12345/EVMap).
In the process have done some improvements to AnyMaps in my fork, as seen in the list below.

Is this project still maintained? Would you be open to PRs for some or all of these changes?

If yes, how should we handle this - one small PR for each of the changes? In that case it may be necessary to have the PRs built on top of each other as not all changes are completely separable from each other. Or I can make one large PR with the features you would like to have.

Major changes

  • Add a MapFragment class (ev-map@830989e, ev-map@e172821), which handles lifecycle callbacks automatically and allows the user to directly set which map implementation should be used. This alleviates the need to import a specific MapView and MapsConfiguration implementation and can automatically select the best backend based on the anymap-... libraries that are available (e.g. if you have one Build flavor for Google Maps and one for OSM, you don't need any flavor-specific code to handle the creation of the map).
  • Add an implementation for Mapbox maps in the anymaps-mapbox module (ev-map@61c95e6, ev-map@ebc4582)
  • Update dependencies (ev-map@1a3b385, ev-map@3d229c8, ev-map@5d14324) and make necessary code adjustments (Android build tools, Support Library, Google Maps, OSMDroid)

Minor changes (relevant for all AnyMaps backends)

Minor changes (OSM)

  • add attribution (ev-map@2a2c032)
  • Disable OSMDroid's zoom controller buttons (ev-map@8613bc3) for consistency with Google Maps, which does not have such buttons by default

Minor changes (Google Maps)