sharkdp/bat

oniguruma has been archived, remove regex-onig build feature?

Opened this issue · 2 comments

dcermak commented

https://github.com/kkos/oniguruma has been archived recently and will not receive any further updates. I would suggest to move away from it and remove the regex-onig build feature:

bat/Cargo.toml

Line 41 in b7f9662

regex-onig = ["syntect/regex-onig"] # Use the "oniguruma" regex engine

keith-hall commented

We can't remove this feature yet, too many syntax definitions rely on Oniguruma functionality which hasn't been implemented in fancy-regex yet... #3274 (comment)

  • 👍2
CosmicHorrorDev commented

It looks like development has picked up again in this repo

~~https://github.com/rust-onig/rust-onig~

jk I see now that it's Oniguruma itself that's archived...