sharmalab/eaglescope

Title Text Should come from config

birm opened this issue · 5 comments

birm commented

Right now, the "title text" is a relic from a demo.

<span className="navbar-brand px-2 mb-0 h1 whitetext" >TCIA Clinical Data Explorer</span>

Instead, read the title from some field in a config file (such as ./config/vis-config.json), with a default value of "eaglescope".

Hello, I am interested in taking up this issue

birm commented

Any support you may need?

Hey, @birm I looked at the code and found that the title is being dynamically rendered according to conditions specified in the getConfig function. Should I take all of those title values and put them in their respective config files? Any help would be greatly appreciated. Thank you.

I also thought of changing the comparison operator from double equals to triple equals when comparing the template name. Should I do this too?

birm commented

I consider the current getconfig to be a temporary solution. Instead some value should be read from somewhere in the config url to populate title.