shashi/Reel.jl

Using which on Windows

mykelk opened this issue · 3 comments

mykelk commented

This doesn't seem to work on Windows (currently starting at line 71 of src/Reel.jl):

        cmd = try readstring(`which convert`)
        catch e1
            try readstring(`which magick`)
            catch e2
                error("Could not find imagemagick binary. Is it installed?")
            end
        end |> strip

The command which is not supported. We end up getting this error:

Could not find imagemagick binary. Is it installed?

when it is actually installed.

tawheeler commented

I tried using the where command on windows instead. Unfortunately travis does not support testing on windows, so I'm not sure I can check whether it worked.

mykelk commented

Yep, where works perfectly. One needs to be careful about convert since that is a command on Windows that converts a FAT volume to NTFS. Does it make sense to use https://github.com/JuliaIO/ImageMagick.jl?

tawheeler commented

Okay, created a new tag.
Switching to ImageMagick would be a good idea. Will add a new issue for that.