shawntabrizi/substrate-collectables-workshop

Math check on Storage Hash Fingerprint section

Closed this issue · 4 comments

https://github.com/shawntabrizi/substrate-collectables-workshop/tree/master/steps/11#hash-fingerprint

For context, a 32-byte hash has 2^32 different possible outputs. This is nearly as many atoms as there are in the whole universe!

Shouldn't this be 2^256 instead?

@Madalosso haha yes :)

Do you want to submit a PR? or I can do it :)

I had this one opened for a few days #191
But today I realized that I was probably doing the change targeting the wrong branch (mdbook).
I can create a new one soon with the fix :)

@shawntabrizi, there it is.
Thanks for the workshop, It was very useful to learn with a hands-on approach

thanks for your feedback and contribution!