np.average, find_hip, astroquery
Closed this issue · 3 comments
mzechmeister commented
Some more suggestions:
- Use
np.average
for the weighted means. - Move
find_hip
to utils whereget_stellar_data
is located. Or even consider to make it part ofget_stellar_data
, e.g.get_stellar_data(name='', hip_id=None)
. - Make
astroquery
import optional with atry
. It adds more dependencies which are not necessarily needed forget_BC_vel
. I have not installed it, since have created my own request tool (https://github.com/mzechmeister/serval/blob/master/src/targ.py)
shbhuk commented
For 1. I think I shall leave it this way, is more explicit and easier to understand if anyone looks at the source code.