sheffieldnlp/naacl2018-fever

Cannot find "OnlineTfidfDocRanker"

Closed this issue · 5 comments

nayeon7lee commented

Hi,
Inside the "process_tfidf_drqa.py" file, there is a line trying to import OnlineTfidfDocRanker (i.e. "from drqascripts.retriever.build_tfidf_lines import OnlineTfidfDocRanker"), however, i cannot locate this file within the provided codebase. Can I know where i can find this file?

j6mes commented

Hi, did all the dependencies install OK when you ran pip install -r requirements.txt?

I have updated some of those recently might be worth upgrading the dependencies again: pip install --upgrade -r requirements.txt (or maybe with --force if needs be).

J

nayeon7lee commented

It works now. Thanks a lot for your help!

j6mes commented

np

chiphuyen commented

The issue didn't resolve for me after I've run the upgrade.
I don't get it -- if OnlineTfidfDocRanker isn't in the drqa code base, how is upgrading it going to fix it?

j6mes commented

The Online Ranker is something I've added to a fork of DrQA - so it wouldn't be in the original code base. In the requirements.txt file, it points to my own fork.

Are you still having issues?