shellscape/postcss-values-parser

Exception thrown on float duration values

bartveneman opened this issue · 9 comments

bartveneman commented
  • Webpack Version: N/A
  • Operating System (or Browser):linux/amd64
  • Node Version: node v10.15.2
  • postcss-values-parser Version: 3.0.2

How Do We Reproduce?

Link to repl.it: https://repl.it/@bartveneman/postcss-values-parser-302-duration-errors

Expected Behavior

parse('.7s') does not throw on time values that are floats

Actual Behavior

parse('.7s') throws <css input>:1:1: Unknown word

shellscape commented

Ah, s as a unit. Can you link to the spec for other valid time-units?

bartveneman commented

Basically s and ms are allowed values. Level 2 defines that values may not be negative, but that note has disappeared from Level 3 onwards.

MDN provides examples with negative values, so might be useful to take that into consideration as well

radeno commented

Any time sheet when this issue will be fixed?
Should be compatible with https://drafts.csswg.org/css-values-4/#numeric-types right?
So just unitRegexp should be updated or is it necessary to make bigger changes?
https://github.com/shellscape/postcss-values-parser/blob/master/lib/nodes/Numeric.js#L17

shellscape commented

@radeno that's probably what needs to be updated, and tests will need to be added as well. I would happily review a pull request for this.

bartveneman commented

I'd be happy to give this a try. Would it bu useful to append something like this to the test array and expand the regex until it doesn't fail?

    '-5deg',
    '5deg',
    '5.5deg',
    '-5.5deg',
    '.5deg',
    '-.5deg',
  • 👍1
radeno commented

@bartveneman i tried to add angle values, but when 90deg was set then test fails. I don't have time to dig deeper. But time values support waits in PR.

bartveneman commented

Ah, sorry, I missed that reference above 😬

glen-84 commented

@shellscape Should this be closed? (by #87)

shellscape commented

Indeed it should. Thanks for the heads up @glen-84 !

  • 👍1