Typescript types

Question

Typescript types

Closed this issue 6 years ago · 8 comments

G-Rath commented 6 years ago

There doesn't seem to be any typescript types 😱

Answer 1 · 2019-09-10T08:50:50.000Z

Hi! There are!
@types/webpack-plugin-serve

Answer 2 · 2019-09-10T08:57:42.000Z

Hi! Those typings don't apply to webpack-nano because they're for webpack-plugin-serve.

I've got those types in my project, but still can't import from webpack-nano/argv.

I'll double check this when I'm back at my computer in ~30 minutes, but pretty sure TypeScript won't like trying to load the @types that have a different name to the package in question.

Answer 3 · 2019-09-10T09:10:03.000Z

Yeah I just checked: those typings don't reference webpack-nano at all, so won't be picked up by the type acquisitioner, nor consumed by TS

Answer 4 · 2019-09-10T09:27:17.000Z

I was half asleep, sorry! I forgot about webpack nano hahaha
If you want you can add those to @types, but I’ll be adding those as I have time this week (pretty busy with work)

Answer 5 · 2019-09-10T12:44:45.000Z

Honest question here: why would a CLI with no API interface need types?

Answer 6 · 2019-09-10T18:48:01.000Z

@shellscape I know, but you can't do import argv from 'webpack-nano/argv' w/o the types.

It's weird one, and I suspect the types will either be just an export of unknown or any, but there is a use-case for require/importing... 🤷‍♀

Answer 7 · 2019-09-10T19:31:01.000Z

Yeah you're absolutely right on that one. That's small enough that I wouldn't be opposed to shipping a d.ts file in the package. Would you be willing to open a small PR for that?

Answer 8 · 2019-09-10T19:59:13.000Z

Sure thing!

I'll make one right now.