shenjunru/fxcanvas

Problems with JooScript

GoogleCodeExporter opened this issue · 3 comments

+1 for dropping JooScript.

First of all I have had to modify it to make it loadable on demand (it uses 
document.write that only works before the document is loaded).
Secondly it seems to break functionality with ExtJS 3.3.1+jQuery (selecting a 
row in a grid does not work anymore) after loading the JavaScript file.

It seems that JooScript doesn't play nicely with other frameworks. If fxcanvas 
is not essential dependent on JooScript it would be nice to drop it.

Original issue reported on code.google.com by joern.h...@gmail.com on 5 Apr 2011 at 10:45

To be more concrete: It seems that JooScript modifies the event objects in the 
IEShim.js:

/*
        Note:
        The Microsoft implementation is the only one that makes sense. button is a bitmask:
          1 - Left button
          2 - Right button
          4 - Middle button

        W3C's definition is:
          0 - Left button
          1 - Middle button
          2 - Right button

        0 should mean "no button pressed", any other meaning is silly. 
        Besides these values cannot be combined into a bitmask: you'll never know 
        whether the left button has been pressed. This definition is very shoddy work. 
      */
      if (event.button == 1)
        eo.button   = 0;

I don't know how and why this has been modified globally but other frameworks 
won't get e.button == 1 anymore so they will fail to analyse which button the 
user has clicked.

As everybody should know it's a very bad thing to change the default 
prototypes/behavior of the browser (Unobtrusive JavaScript).

Original comment by joern.h...@gmail.com on 6 Apr 2011 at 7:43

Hi,

To be honest, JooScript is devilish  research project, so that I make up my 
ideas and try   it on my victims =)

But seriously, Joo is an integrated part of fxcanvas and other my progs based 
on it, so that splitting the code would be painful job... 

Anyway, tanks for comment! I'll see what can I do.

Original comment by buzz...@gmail.com on 7 Apr 2011 at 6:42

  • Changed state: Accepted
  • Added labels: Priority-Low, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect
Okay, I understand.
I filled bugreports at JooScript, too and it seems that they will address those 
issues. Great news and thanks for your work!

Original comment by joern.h...@gmail.com on 7 Apr 2011 at 7:37