shepherd-pro/shepherd

Doubts about the "close" event.

didaquis opened this issue · 3 comments

Hi. I noticed that the documentation refers to the "close" event in a code example. However, it does not appear detailed in the event listing.

I have the feeling that this event does not exist and that it is an error in the documentation.

Captura de pantalla 2023-02-20 a las 11 13 22

Seems like this example was introduced here: #1086

No, there is no close event. You'll want complete or cancel. It's likely the person who added that example just picked something random to use. All possible events are here

const events = [

thanks @RobbieTheWagner, I thought so. I was looking at the source code and found no reference to that event.

I have made an PR to fix it. Take a look at it when you can. Thanks!