shipshapecode/shepherd

Accessibility Findings using Axe DevTool (chrome extension)

Closed this issue · 2 comments

ise193 commented

This is a very neat tool. Our team is very interested in using your tool for integrated on-line help guides. We are encouraged that your library is Accessibility compliant, however, have noticed a couple of Accessibility findings were introduced when including into our environment. We found a couple of findings (even on your own website) listed below, using Axe Developer Tools (chrome extension):

• "Document should not have more than one banner landmark."(moderate finding) – appears to be a finding because of the help dialog overtop of the page in the background, as both have banner landmarks
• "Landmarks should have a unique role or role/label/title (i.e. accessible name combination) (moderate finding)" – (related to finding above) appears to be a finding as there are two header and two footer attributes (due to the help dialog overtop of the page in the background)
• "Document should not have more than one contentinfo landmark (moderate finding)" – Related to issues above (two footers are present)

Do you see any of these accessibility findings on your side? If so, are there any future plans to address these accessibility findings?

Thank you for your time and we look forward to your response!

Hi @ise193, we could probably switch the header and footer to just be divs, but that feels not ideal. I wouldn't think these things would be actual issues because Shepherd focus traps the user, so I don't think you could even access the elements outside of Shepherd accidentally, but I am not sure.

ise193 commented

Hi @RobbieTheWagner. Thank you for the quick response and clarification!