shipshapecode/shepherd

String continuations are not recommended

Opened this issue · 2 comments

furkan3ayraktar commented

According to the Google JavaScript Style Guide, string continuations are not recommended.

When using shepherd from ClojureScript (which uses Google's Closure Compiler), we get several warnings during compilation due to the line continuations used in the below file:

https://github.com/shepherd-pro/shepherd/blob/eb1c90ca77a8ed94a9df20d08534311c969042cd/src/js/utils/overlay-path.js#L22-L37

Is there a way to implement the same functionality without using line continuations?

sirmspencer commented

I see the same thing.

chuckcarpenter commented

I know it's been a bit, but open to suggestions or PRs @furkan3ayraktar @sirmspencer ?