sherif-fanous/Pyecobee

Undefined object - Thermostat --> Reminders

fowlerk opened this issue · 1 comments

If the Selection parameter 'include reminders = True' is specified for the call to request_thermostats, and reminders are returned in the response contents, a key error occurs. This is apparently because of an undefined object for Reminders, which include the following attributes: type, title, description, reminderDate, and remindMe. (All are six.text_type except the last, which is bool.)

The Ecobee website documentation mentions an object ThermostatReminder2[] as an attribute of the Thermostat object, but I have not found a definition for this object. The Pyecobee library includes references for this object, including in the attribute_type_map in thermostat.py. However, it appears the object name should be Reminder (as this is the key returned in the response) and a new definition created for it (reminder.py).

See my suggested changes to address: #19