shidel/FDI-x86

floppy installer backup feature broken

dajhorn opened this issue · 5 comments

dajhorn commented

The FreeDOS 1.3-RC5 floppy installer always fails if the user chooses a system backup:

Creating backup of previous OS files to C:\BACKUP.001.

ERROR #1, Subprocess error
Failed.

CRITICAL error: Unable to backup files in target directory.

The installation of FreeDOS 1.3-RC5 has been aborted.
dajhorn commented

DOSBox-X Screenshot

FDI-x86 1 5-RC5 Backup Error

shidel commented

Note to self: There is also a reference to this issue at the FreeDOS archive as FDI-x86 Issue 4. Once corrected, both will need marked fixed.

shidel commented

After investigating the issue, the problem occurs at Line 226. When XCOPY is told to copy an empty directory it returns an error code. When the OS is installed using the FloppyEdition, both %DOSDIR%\LINKS and %DOSDIR%\TEMP are empty and cause XCOPY to generate an error and the backup process to fail.

Unless an easier work-around can be though of, this will probably require additional functionality added to vfdutil to test if a directory is empty.

Since both FDI and FDI-x86 use a similar method to backup the old DOS files, this issue will also effect the primary installer as well as FDI-x86.

shidel commented

With update to V8PowerTools and a test for empty directories before attempting to use xcopy made within FDI-x86, the issue should be resolved. Just needs testing now.

shidel commented

Confirmed, fixed using new build of V8Power Tools.

Note: Primary installer was not affected by this. It had a different work-around using pipes, dir and vstr to prevent the issue. FDINS200.BAT in FDI may be updated to use the better solution provided by the VFDUTIL empty directory test.

  • ❤️1