Extend AEM stop verification in AEM Upgrade scripts
Closed this issue · 1 comments
Is your feature request related to a problem? Please describe.
In some cases the current implementation of verifying if the AEM Service is up and running or stopped is not be sufficient enough and response with a false positivel
Currently we are only verifying if the AEM Java process is running or not https://github.com/shinesolutions/puppet-aem-curator/blob/master/templates/aem-tools/upgrade-aem-script.sh.epp#L54.
Sometimes the PID doesn't exists anymore but the control file crx-quickstart/conf/controlport still exists because AEM is still stopping in the background.
The next step in the upgrade process is to start AEM once the PID doesn't exists anymore this startup will fail if the control file still exists. Therefore we should also verify if the control file still exists.
Describe the solution you'd like
On top of verifying if the PID exists we should also verify if the control file exists.
Describe alternatives you've considered
none
Additional context
none
This is definitley not thee right approach. The test failed.