shinneider/django-admin-search

Move css inside a html to external file

Closed this issue · 6 comments

shinneider commented

In the file django_admin_search/templates/admin/custom_search_form.html has many lines of css.

i need to move this lines of css, to a external css file, loaded in the html

gabbyprecious commented

Hello, I would love to work on this if it has not been achieved, can I work on it?

shinneider commented

Hi @gabbyprecious

can work on it :)

Assign to you and create a Pull Request to develop branch on finish.

gabbyprecious commented

I have sent a pull request, Please review and correction will be appreciated

  • 👍1
shinneider commented

hi @gabbyprecious

i see the PR, and added a same comments, but i noticed that several "django tags" is reordened, not using a common django template recommendation.

however it seems to be something with its IDE (because they are lines of code that you haven't changed)

change not edited lines to back style and i approv the PR.

taking out of this inconvenience, it was very good job.

Nice. very thanks to contribute.

gabbyprecious commented

Hello I have sent a new pull request

  • 👍1
shinneider commented

Hi @gabbyprecious

I approved and in the next release (0.3.4) your code will be present. :)

as there is no loss or gain in performance or any bugs, I will not upload the version immediately
wait to another issue to create a new version