Upgrade to PHP-Parser 5
Closed this issue · 5 comments
Recent phpunit/phpunit:^11, released on February 2, 2024, requires nikic/php-parser ^5.0.
However, phpstan-rules:2.11.12 requires nikic/php-parser": "^4.14.0.
Upgrading PHPUnit is therefore blocked by phpstan-rules.
PHPUnit looks to me a popular quality tool to run alongside PHPStan, therefore phpstan-rules should consider updating.
Note that setting the nikic/php-parser": "^4.14.0 dependency as dev dependency will solve the issue (as in phpstan-strict-rules)
Maybe consider PR #221
How will that help, given that phpstan itself requires nikic/php-parser 4?
Hello @JanTvrdik , thanks for considering my issue.
Nope PhpStan does not requires nikic/php-parser 4 https://github.com/phpstan/phpstan/blob/1.10.x/composer.json
And phpstan-struct-rules only require it as a dev dependency https://github.com/phpstan/phpstan-strict-rules/blob/1.6.x/composer.json
I'll remove the dependency, it does not make sense to have it there as it wont be used at all.
Thanks for the report.