shipmonk-rnd/phpstan-rules

forbidUnsetClassField disable is not respected

Closed this issue · 2 comments

jakubvojacek commented

Hello

seems like the rule ForbidUnsetClassFieldRule is registered twice. When I unset some property from a class, it's reported twice. When I disable the rule by

 ------ ---------------------------------------------------------------------------------------- 
  Line   ApiModule/Model/XXX.php                                                              
 ------ ---------------------------------------------------------------------------------------- 
  869    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
  869    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
  870    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
  870    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
 ------ ---------------------------------------------------------------------------------------- 

		forbidUnsetClassField:
			enabled: false

 ------ ---------------------------------------------------------------------------------------- 
  Line   ApiModule/Model/XXX.php                                                              
 ------ ---------------------------------------------------------------------------------------- 
  869    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
  870    Unsetting class field is forbidden as it causes un-initialization, assign null instead  
 ------ ----------------------------------------------------------------------------------------

its reported once.

Thanks
Jakub

janedbal commented

I cannot replicate that, it is registered only once.

This looks like double registration within your project. If you used this package before version 2.0.0, all rules were required to be registered manually. Maybe you kept old registration when upgrading?

jakubvojacek commented

Maybe you kept old registration when upgrading?

yes, spot on, sorry for bothering, I upgraded and deleted all the rules except for this one, missed one like 🤦

Thanks for the library tho, most of the rules are super useful

  • 👍1