shirsig/unitscan

[Request] Please add volume control

Closed this issue · 1 comments

This addon is great except the sound effect always plays at the maximum volume for me. The sound effect that plays in the addon seems to use the master audio channel which I keep at 100% (and I suspect most people do unless they mute the entire game) because I adjust the individual sliders like effects, music, ambiance, and dialog.

Could we please get a command like /unitscan volume 1...100 to set the volume of the effect between 1 and 100 percent?

I was considering this request based off of how the RareScanner addon has this feature. It turns out that addon simply has lower volume .ogg files that play depending on which volume level you set.

I decided to tackle this request as well as #19 myself as I figure a bit of wow addon dev exposure wouldn't be bad. Of course it's based on what I could google mostly, so the code isn't that unique but I will submit a PR for you to evaluate.