Probably typo in Chapter 7 Xgboost

Question

Probably typo in Chapter 7 Xgboost

Opened this issue 5 years ago · 4 comments

gelotran commented 5 years ago

Hi,

Can you check the formula in the part 7.4.3 Xgboost? I think there may be a typo there.

Then the formula 7.5 has to be adjusted accordingly.

Best,
Vu Tran

Answer 1 · 2020-04-17T16:16:07.000Z

Thanks for the feedback!
I've checked again, and it seems ok to me, given the 2 factor in front of the sum...

Answer 2 · 2020-04-17T17:44:50.000Z

Hi,

Thank for feedback. I take a comparison with XGBoost website.

It seems that inside each tree leaf, we sum all the Hessian values but not a summation of \lamda.

Btw, your book is great for an R user working with Portfolio ML. I enjoy reading it a lot.

Answer 3 · 2020-04-17T18:43:57.000Z

True, but I prefer to take the simpler case when the loss is quadratic (easier to follow I find).
And for a quadratic loss, the Hessian is constant.
That's why I get differences w.r.t to the original derivation with "2" factors at some places.
Thanks for the feedback again: don't hesitate because we really want to continuously improve the book.

Answer 4 · 2020-04-17T19:09:05.000Z

You're welcome. Thank for clarification

It's actually a good book. I hope that you can continue to work on it and looking to see further work from you.