showdownjs/table-extension

Is `Showdown` or `showdown` ?

pizn opened this issue · 2 comments

pizn commented

Hello.

The namespace need be showdown not Showdown. The code here.

What difference of that? What to consider when you modify the namespace?

The namespace need be showdown not Showdown. The code here.

In the current "stable" version, the namespace is Showdown. (see here)

In the 1.0.0-alpha.1 the namespace was changed to showdown.
The table extensions will be updated accordingly when we release showdown core library 1.0.0 stable.

What difference of that? What to consider when you modify the namespace?

Not much, just consistency with most of javascript conventions and with the lint tool we use for build. Usually javascript programmers expect camelCase for regular identifiers (including namespaces), CAPSLOCK for "constants" and ProperCase for object constructors (indicating they should always be invoked using new).

So, in V1.0.0 Showdown.converter() becomes showdown.Converter()

pizn commented

Nice, thank you :D