showtime-xyz/showtime-frontend

tooltip is installing react-native-mmkv

itsramiel opened this issue · 2 comments

I am trying to use @showtime-xyz/universal.tooltip, but I get the following error:

Error: react-native-mmkv is not supported in Expo Go! Use EAS (`expo prebuild`) or eject to a bare workflow instead.

running yarn why react-native-mmkv results in

yarn why v1.22.17
[1/4] Why do we have the module "react-native-mmkv"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "react-native-mmkv@2.3.3"
info Reasons this module exists
   - "@showtime-xyz#universal.tooltip#@showtime-xyz#universal.hooks" depends on it
   - Hoisted from "@showtime-xyz#universal.tooltip#@showtime-xyz#universal.hooks#react-native-mmkv"
info Disk size without dependencies: "1012KB"
info Disk size with unique dependencies: "1012KB"
info Disk size with transitive dependencies: "1012KB"
info Number of shared dependencies: 0

Not sure what is going on but I dont think tooltip needs mmkv

Hi, @ramiel1999!
thanks for your feedback!
we currently use mmkv to store the color-scheme key, indeed it is unnecessary!
next, our team will also start to consider these issues.

react-native-mmkv has been removed in #1183, so close this issue.