shpaass/yafc-ce

[Discussion] Remove build.bat

Closed this issue · 6 comments

I use build.sh to make releases on Windows. For that, I use GitBash with the zip command installed on top of it, and I will continue to use it in the forseeable future. Therefore, I wanted to know if anyone uses build.bat at all.

This issue is related to #205 in a sense that if we delete build.bat, then we don't need to bother with implementing the version-fetch in cmd.

I made the bash build script for when I made a non-official YAFC with some fixed a while back. I maintained the bat script to keep it in sync. (I guess @ShadowTheAge used it).

So for me we do not keep the script.

I also think it's fine to delete the batch script; having one release script is better than trying to maintain two, especially when they start getting complicated.

done
2e2ae23

I used it ❗

But if we don't want to maintain it that's ok, i can write my own script locally. All i used it for is to have a separate latest master from my own code modifications.

The script is still there. You just need to checkout the commit before the one that deletes the script, and then you can keep it in your branch or git stash.

To be more precise, you can revert the commit 2e2ae23 in your branch. After that, you can rebase this branch as needed and check it out when you want to use it.

Apologies for the inconvenience.