shravan20/github-readme-quotes

Quotes based on Specific Personality

Opened this issue · 4 comments

Is your feature request related to a problem? Please describe.
Create Quotes taken from your favourite personality

Describe the solution you'd like

  • You can use existing API that provides this functionality

Describe alternatives you've considered
Create a folder, storing JSON file storing all personalities quotes in natural order (Aplhabetical order)

would like to take up this issue.
Implementation plan:
-implement a personality search box
-use Axios and Cheerio to crawl Goodreads quote search
-pick a random quote from the first page and display it.
-If no quote is found, display the warning text "no quote found " under the personality search bar.

If this implementation plan sounds good please let me know.

heroku service to get quotes is ready

 axios
  .post('https://qoutescraper.herokuapp.com/quote/author', {
    author: "Mahatma Gandhi"
  })
  .then(quote=> {
    console.log(quote)
  })
//output
//"Prayer is not asking. It is a longing of the soul. It is daily admission of one's weakness. It is better in prayer to
//have a heart without words than words without a heart."

//—
//Mahatma Gandhi'

Hi @shravan20,

I wanted to check if this enhancement is still necessary. If so, I'd appreciate knowing if any progress has been made on it. I'd be interested in picking this up and working on the issue if it's still open.

@marceloams : This is open to for development, you can feel free to pick this up