shrinerb/content_disposition

URL encoding only in legacy UTF-8 parameter

TrevorHinesley opened this issue · 1 comments

When doing:

ContentDisposition.inline("02 TEST (FILE)_V1 MASTER.wav")

I get:

"inline; filename=\"02 TEST %28FILE%29_V1 MASTER.wav\"; filename*=UTF-8''02%20TEST%20%28FILE%29_V1%20MASTER.wav"

But the documentation says it should be URL encoded in both parameters. Any ideas?

Relevant language from docs:

To support old browsers, the filename should be the ASCII version of the filename, while the filename* parameter can be used for the full filename with any potential UTF-8 characters. Special characters from the filename need to be URL-encoded in both parameters.

Ahh nevermind I misread this. Only special characters are encoded in both. Thank you!