Reviewed and cleaned svg-android-2 patchset
Opened this issue · 1 comments
GoogleCodeExporter commented
I have refined the svg-android-2 patchset originally contributed to this
project by issue 8, with extensive review and testing to provide reasonable
assurance that nothing regresses.
The refinements specifically were:
# Rejected the questionable <use> tag support that was added in svg-android-2. This change introduced significant performance regressions by requiring a two-pass parse of the SVG document.
# Corrected unintended (?) whitespace/formatting changes to make applying the patches easier to swallow.
Attached is a tarball of git format-patch over the new changeset. They can be
applied with git am if using git-svn, or simply by looping through each file
and using patch -p1 < foo.patch (however the latter approach loses meta data
which I worked hard to preserve *grin*).
Note that patch 5 is missing from the set which removes R.java from version
control and updates to the latest Android build tools. Obviously I would
encourage the upstream maintainers to do the same but I don't think it belongs
in this patchset.
Original issue reported on code.google.com by jasta00@gmail.com
on 13 Jul 2012 at 8:08
Attachments:
GoogleCodeExporter commented
These patches are currently applied at the tree here:
https://github.com/mrn/svg-android.
The upstream folks have been asked to use this repository as the primary one.
Original comment by jguilfo...@pointinside.com
on 16 Oct 2012 at 11:41