shurcooL/markdownfmt

Blackfriday v2 version

jsternberg opened this issue · 4 comments

Hello, is there an interest in a version of this updated for blackfriday v2? I figured that there probably wasn't since it would likely be backwards incompatible for anyone embedding the library, but I thought I would ask just in case.

I've created a version at jsternberg/markdownfmt and I can create a pull request for it if there is interest.

I'll be able to look at this more later, but I'm very interested in this! I've wanted to update markdownfmt to blackfriday v2; the only reason I haven't is because I've had higher priorities that prevented me from doing this.

From a quick look at your commits, you said there it's passing the original tests. That's really good to hear, as that's important for me to be able to upgrade.

Thanks for doing this and for letting me know!

Cool. I'll make sure to make a separate branch then that doesn't contain the fork specific code and make a pull request later today or tomorrow.

Are there any plans to upgrade to v2? The referenced PR seems to be quite out of sync now. Is there any way to help progress this?

I've had many other priorities and haven't gotten around to this yet.

As suggested in #40 (comment), you can use @jsternberg's fork if you want a version of markdownfmt that uses blackfriday v2 now.