Using with image/png

Question

Using with image/png

Closed this issue 6 years ago · 7 comments

radykal commented 6 years ago

Is it correct that you can only use jpeg, I am trying to use this project with data urls encoded in image/png?!

Answer 1 · 2018-07-05T09:36:39.000Z

Hi @radykal, it works with pngs too.

Did you encounter some problem trying to make it work?

Answer 2 · 2018-07-05T10:52:10.000Z

removepHYs is not defined.
removepHYs = true;

I checked your code and its not defined with var. This is caused by strict mode.

Answer 3 · 2018-07-05T11:01:51.000Z

i ll check it and fix it, thanks.

Answer 4 · 2018-07-05T11:30:16.000Z

I think the code in DIST is not updated. that removepHYs is an overwritepHYs.

I'll rebuild the lib and republish the npm package.

Answer 5 · 2018-07-12T06:51:08.000Z

@asturur did you get around to updating the NPM package? I am still encountering this issue

Answer 6 · 2018-07-12T12:00:45.000Z

i could not republish yet, i should be able to do it today.

Answer 7 · 2018-07-12T13:17:04.000Z

i just published 1.0.3 with the file rebuilt, sorry for the confusion in the first place.
Let us know possible improvement or difficulties with the lib.