shystruk/react-native-android-currency-formatter

Wrong return type on numberFormat and numberFormatAsync

hyperremix opened this issue · 2 comments

Hello and thanks for creating this package!

Right now numberFormat and numberFormatAsync return number and Promise<number> respectively. This should probably be string and Promise<string> instead since that is what is returned from the native module.

Best regards,
Fredrik

Hi @hyperremix
Good catch. Thank you for reporting this 👍

close at 82dd39c