sid88in/serverless-appsync-plugin

[v2] - Error when using AMAZON_COGNITO_USER_POOLS as additionalAuthentications type

jeremy-white opened this issue 2 years ago · 6 comments

jeremy-white commented 2 years ago

In my serverless.yml I have:

  authentication:
    type: AWS_IAM
  additionalAuthentications:
    - type: 'AMAZON_COGNITO_USER_POOLS'
      config:
        userPoolId: xxxx

Upon deploy this results in the error:

UPDATE_FAILED: GraphQlApi (AWS::AppSync::GraphQLApi)
Property validation failure: [Encountered unsupported properties in {/AdditionalAuthenticationProviders/0/UserPoolConfig}: [DefaultAction]]

Problem appears to be that DefaultAction is always set here, when it's only valid for authentication not additionalAuthentications

serverless-appsync-plugin/src/resources/Api.ts

Line 421 in ded4339

DefaultAction: auth.config.defaultAction || 'ALLOW',

marcelinhov2 commented 2 years ago

I had the same problem and was not able to configure both auth methods.

bboure commented 2 years ago

Thank you @jeremy-white and @marcelinhov2
This is a bug. I will fix it

🎉1

github-actions commented 2 years ago

🎉 This issue has been resolved in version 2.0.0-alpha.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

ugurhicyilmam commented 2 years ago

Maybe documentation should be updated too? https://github.com/sid88in/serverless-appsync-plugin/blob/alpha/doc/authentication.md

👍1

bboure commented 2 years ago

Thanks, will do

github-actions commented 2 years ago

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀