issue: Conform gh-action doesn't fail when check fails

Question

issue: Conform gh-action doesn't fail when check fails

jwnx opened this issue 5 years ago · 6 comments

Conform logs checks as failed, but doesn't report the action as failed. This is a problem because when using conform as part of a larger Github Actions pipeline, it requires reviewers to check workflow logs to ensure all conform checks passed.

Answer 1 · 2019-12-08T17:18:52.000Z

@jwnx Thanks for reporting. That certainly isn't the expected behavior. Does conform report success at all, or are the statuses on the PR missing?

Answer 2 · 2019-12-08T17:26:24.000Z

Hi @andrewrynhard (:
Thanks for answering! Conform reports sucess. Here's a screenshot:

Answer 3 · 2019-12-08T18:08:11.000Z

@jwnx What about on the PR? It should be creating PR statuses.

Answer 4 · 2019-12-08T19:09:44.000Z

@jwnx Looks like I just need to cut another release: 365c592

Answer 5 · 2019-12-08T21:55:47.000Z

@jwnx I just created a release to the marketplace. It should have the fix you need. I had to get things in order so that I could publish to the marketplace, so things may have changed. Give it a test and let me know 👍.

Answer 6 · 2020-01-11T23:20:37.000Z

It works now! Tested on docker://autonomy/conform:v0.1.0-alpha.17 (: