siderolabs/conform

Run on multiple commits during a pull_request

priyasiddharth opened this issue · 5 comments

priyasiddharth commented

Hello,

I had conform as a github action but on a pull request/push with multiple commits - it only appears to run on the latest commit.

How can I make it run on every commit in the diff with the base branch?

This is my config
action - https://github.com/seahorn/seahorn/blob/master/.github/workflows/conform.yml
config - https://github.com/seahorn/seahorn/blob/master/.conform.yaml

thanks
Siddharth

andrewrynhard commented

hello, that is currently not possible, but i would be happy to accept a PR

priyasiddharth commented

I will not have cycles to fix this as of now. I will atleast try to send an update to the README to mention this limitation.

  • 👍1
janderssonse commented

@priyasiddharth It seems multicommit support was added in this commit, however it is not really documented. 9023e3a

JossWhittle commented

@priyasiddharth It seems multicommit support was added in this commit, however it is not really documented. 9023e3a

Any idea how to enable this in a Github Actions workflow? There's a ton of potential in this tool but the documentation is lacking to make that feasible.

  • 👍1
janderssonse commented

@JossWhittle I got it working in a GH workflow by doing this->. https://github.com/janderssonse/janderscripts/blob/main/.github/workflows/dco.yml. It runs on pr's only, and checks all commits on that pr against main branch, but skips if not on a pr. Also look at the .conform.yaml in the project for settings i used. Note: (The GH checkout action needs a special ref setting, otherwise it will only check the merge commit, there are a few issues about that on the GH action issue tracker for example actions/checkout#881 ).