on linux , 'make install' also adds system libraries
fenugrec opened this issue · 4 comments
fenugrec commented
vaguely related to #29 (cmake improvements).
Trying to package this for Archlinux, with default options cmake is bundling some systemwide libraries (libstdc, libgcrypt, libc, etc...) at the cmake --install
step.
Does this have to do with the RUNTIME_DEPENDENCY_SET
stuff in /etc/packaging.cmake ?
install_manifest.txt:
...
/usr/bin/srec_cat
/usr/bin/srec_cat
/usr/lib/ld-linux-x86-64.so.2
/usr/lib/libc.so.6
/usr/lib/libgcc_s.so.1
/usr/lib/libgcrypt.so.20
/usr/lib/libgcrypt.so.20.4.1
/usr/lib/libgpg-error.so.0
/usr/lib/libgpg-error.so.0.33.1
/usr/lib/libm.so.6
/usr/lib/libstdc++.so.6
/usr/lib/libstdc++.so.6.0.30
/usr/bin/srec_cmp
/usr/bin/srec_cmp
/usr/lib/ld-linux-x86-64.so.2
/usr/lib/libc.so.6
/usr/lib/libgcc_s.so.1
/usr/lib/libgcrypt.so.20
/usr/lib/libgcrypt.so.20.4.1
/usr/lib/libgpg-error.so.0
...
(interesting to note : lots of duplicates...)
sharkcz commented
I see the same issue on Fedora, this is simply wrong for any Linux installation.
sharkcz commented
The commands starting with https://github.com/sierrafoxtrot/srecord/blob/master/etc/packaging.cmake#L33 needs to be guarded by if (WIN32)
as they are meant for Windows only.
sierrafoxtrot commented
Thanks @sharkcz. Should be a straight forward fix.
nieder commented
Also affects macOS builds