`Mjml::Parser#render` suppresses errors in case of Tempfile exceptions

Question

`Mjml::Parser#render` suppresses errors in case of Tempfile exceptions

Closed this issue 3 years ago · 2 comments

In case of an exception in Tempfile.open the in_tmp_file in the current ensure block is nil, which lets to another exception when calling unlink. This shadows the original exception.

We encountered this issue in context of a Docker environment and fixed this via a monkey patch.

Are you interested in a pull request, ideally with a test case?

Answer 1 · 2021-12-10T22:41:21.000Z

@der-flo A PR with a test case would be excellent thanks.

Answer 2 · 2021-12-13T18:14:14.000Z

It's on my list for the coming friday. Stay tuned.