Adopt GDI specification v1.5.0
pellared opened this issue · 11 comments
I'm not sure what this entails. Did you have a specific set of requirements in mind?
For sure check the "Repository" requirements as these contain some changes and I am not sure if this repository has ever adopted the GDI spec.
Also I believe that https://github.com/signalfx/gdi-specification/blob/v1.5.0/specification/configuration.md#data-collector should be double checked.
It never has adopted this specification indeed. Is there a rationale to adopt this specification now? Is this a requirement from the standpoint of a specific initiative?
GDI repositories MUST adopt GDI specification changes by their next MINOR release and within three months (whichever is sooner). The GDI specification and GDI repositories MUST remove any deprecated specification at the next MAJOR release.
Source: https://github.com/signalfx/gdi-specification/blob/main/README.md
@pellared are you able to provide examples of suggested changes (maybe in a PR) as opposed to a blanket request?
@rmfitzpatrick Has this repository ever adopted the GDI spec? If not then I suggest looking at GA request. If at some point of time the GDI spec was adopted then you can look at the CHANGELOG.md
@rmfitzpatrick Has this repository ever adopted the GDI spec?
No and this is the first correspondence involving this project* I can recall.
We have done a bit more review internally and we will pull in elements of the specification to adopt it gradually. I will open additional issues and link to this one. We have been looking to support CODEOWNERS for example for a bit. We will work towards adopting all the elements over time.
We have done a bit more review internally and we will pull in elements of the specification to adopt it gradually. I will open additional issues and link to this one. We have been looking to support CODEOWNERS for example for a bit. We will work towards adopting all the elements over time.
You can also propose changes in the GDI specification.
For instance, I would consider removing the "Data Collector" section as there is only one distribution of collector, operator etc
Closing, superseded by #3637