sigstore/helm-charts

Duplicate fields in policy-controller causing Flux v2 reconciliation failure

DonaldKellett opened this issue · 3 comments

Summary

Duplicate fields in policy-controller causing Flux v2 reconciliation failure as shown in the screenshot below

policy-controller-flux-failure

Steps to reproduce

The issue appears with the default policy-controller Helm chart configuration since version 0.6.6.

Run the following commands:

helm repo add sigstore https://sigstore.github.io/helm-charts
helm repo update
helm template \
    policy-controller \
    sigstore/policy-controller \
    --version 0.6.6 \
    --show-only templates/webhook/deployment_webhook.yaml | \
    yq '.spec.template.metadata.labels'

Output:

app.kubernetes.io/name: policy-controller
app.kubernetes.io/instance: policy-controller
control-plane: policy-controller-webhook
helm.sh/chart: policy-controller-0.6.6
app.kubernetes.io/name: policy-controller
app.kubernetes.io/instance: policy-controller
app.kubernetes.io/version: "0.8.2"
app.kubernetes.io/managed-by: Helm

Notice the duplicated app.kubernetes.io/name, app.kubernetes.io/instance fields.

Software version information

sigstore/policy-controller version 0.6.6 (issue did not appear prior to 0.6.6)

  • Kubernetes client version: v1.28.3
  • Kubernetes server version: v1.28.3+rke2r2 (Rancher RKE2)
  • Helm version: v3.13.2
  • Flux version: 2.1.2

@DonaldKellett Let me fix that. It is related to a recent change.

Just confirmed the issue is fixed in #669 after upgrading to 0.6.7, thanks!