silinternational/idp-id-broker

Once finished, check our implementation against the final version of our api.raml spec

forevermatt opened this issue · 10 comments

Once we believe the implementation of this is done, let's do a final comparison (ideally using an automated tool, even if only run once) between the implementation and the RAML spec.

I believe this will be done after #41 is merged.

If it's not hard, I'd still be interested in some software comparing the RAML spec file against the working version, if only because I have such a low level of confidence in my own ability to spot possible differences.

lvail commented

Neither @forevermatt nor I will be there on Fri, would it be worth it to you to do it over video conference?

That part aside, are we suggesting not closing this until we've reviewed it together? If so, I need to remove a comment from my current PR that will resolve this issue.

lvail commented

@forevermatt I'll dig around a bit here and see if anything exists that will take in RAML and some local endpoint configs, e.g., hostname, and run some tests. I don't suppose you've seen anything crop up since you had this thought have you?

@wcjr That page is all I've really had to go on. Postman might be useful, but you have more experience than I do with that.

well, after investigating some tools and considering the 1.0 version of RAML, I'm not sold this will be worth it in the end. The RAML file is a nice communication/collaboration tool when building up the API and possibly even documenting to new users (provided it were prettied up a bit) but the idea of running more tests against it and the infrastructure needed to accomplish that just isn't worth it to me. In the end, we have some good progress on the Behat tests for coverage. This just feels like another maintenance burden when/if things change. I'd like to either close this or leave it to you @forevermatt if you're compelled.

What do you think @fillup and @forevermatt ?

@wcjr Okay that's fine. Thanks again for looking into this.