sillsdev/chorus

Build ChorusMergeModule (and ChorusHubInstaller?)

Opened this issue · 3 comments

ermshiperete commented

When we moved the build to GitHub Actions building the ChorusMergeModule and ChorusHubInstaller was accidentally left out.

We should add building the ChorusMergeModule to dotnet.yml and save it as an artifact.

Also check if the ChorusHubInstaller is still needed - in a discussion on slack it was noted:

Looks like ChorusHub was last released for Windows in 2018 and the most recent successful TC build was in 2017. I don't know what the current process is, if any.
getting rid of build/ may be safe. After so much bit rot, it may be easier to rewrite the installer from scratch if we need to.

However, it seems that ChorusMergeModule.msm and ChorusHubInstaller.msi got build as part of the regular builds (targets Installer ChorusHubInstaller).

Check build/Chorus.proj prior to commit e7ab5bc and TC for how it was done in the past.

ToDo

  • Add building ChorusMergeModule to dotnet.yml
  • Is ChorusHubInstaller still needed/used by anyone?
  • If it is, add building ChorusHubInstaller to dotnet.yml
  • document (e.g. in dotnet.yml) where ChorusMergeModule (and ChorusHubInstaller) is used
    (in FieldWorks and FLEx Bridge installers)
  • (nice to have) automatically stamp copyright dates on both
  • Remove Build/Chorus.proj
jasonleenaylor commented

Yes we still need to be able to build the ChorusHub installer.

papeh commented

Well, the Chorus Hub installer builds, but when I try to send to it, it fails to get the remote project.

Exception: The internet server reported that it is having problems. There isn't anything you can do about that except try again later.
   at Chorus.VcsDrivers.Mercurial.HgRepolitory.PullFromTarget(String targetLabel, String targetUri)