sillygod/cdp-cache

Incorrect handling of status codes.

Closed this issue · 5 comments

AlbinLindskog commented

cdp-cache does not handle non-200 responses correctly. The content of the response is handled correctly, but the status code is changed to 200.

Here is a bare-bones project that demonstrates the issue: https://github.com/AlbinLindskog/cpd-cache-bug

sillygod commented

Hi @AlbinLindskog ,

Thanks for filling this issue, I've made a PR( #36 ) to fix this bug.

AlbinLindskog commented

Impressive! Speedy work. I've confirmed that it works in our setup.

Consider releasing a new version with this fix. xcaddy uses the latest version, not the latest commit, so anyone installing the with xcaddy will end up with 0.4.2, unless the explicitly specify the commit.

sillygod commented

Impressive! Speedy work. I've confirmed that it works in our setup.

Consider releasing a new version with this fix. xcaddy uses the latest version, not the latest commit, so anyone installing the with xcaddy will end up with 0.4.2, unless the explicitly specify the commit.

Sure, I will create a new release. thx.

sillygod commented

@AlbinLindskog ,

I've created a new release.

  • 🎉1
sillygod commented

@AlbinLindskog ,

If it's no more problem, I will close this ticket.