Submitting a FormBuilder form submits all FormBuilder forms

[emteknetnz]

If there are multiple FormBuilder forms at once, submitting one will submit all of them

This bug was worked around on the following PRs:

• silverstripe/silverstripe-linkfield#190
• silverstripe/silverstripe-elemental#1133

We should:

• Work out a way to prevent this from happening
• Remove the workaround code in the two PRs above

Acceptance criteria

• When submitting a nested form builder form, only the form attached to the action that triggered the submission gets submitted.
• Hack working around this bug are removed.

Related

• #1631

INSTALLER CI RUN

This CI run shows the PRs working nicely together.

• https://github.com/creative-commoners/silverstripe-installer/actions/runs/8058908144

PRs

• #1694
• silverstripe/silverstripe-elemental#1151
• silverstripe/silverstripe-linkfield#239
• silverstripe/silverstripe-behat-extension#266

[maxime-rainville]

Just to clarify, is the problem only for nested form builders. Or if you have two form builders next to each other without one containing the other, will one form submit the other?

[emteknetnz]

I'm not sure if the asset-admin form builder that was getting submitted in the first example was even technically nested, it just an a human user level it appears to be nested.

I don't know if it makes a different if they're nested or not, it felt very much like there was some sort of 'submit event' being broadcast that was the was being subscribed to

[sabina-talipova]

PRs have been merged. Task is completed.